Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag name filtering #3822

Merged
merged 24 commits into from
Jul 10, 2024
Merged

Tag name filtering #3822

merged 24 commits into from
Jul 10, 2024

Conversation

joe-elliott
Copy link
Member

What this PR does:
Adds a q= parameter to the /api/v2/search/tags endpoint that allows for filtering down tag names in the same way as the tag values endpoint.

Notes:

  • Instead of pulling and parsing all dedicated and well known columns we are just including them if they have any values.

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Signed-off-by: Joe Elliott <[email protected]>
Signed-off-by: Joe Elliott <[email protected]>
Signed-off-by: Joe Elliott <[email protected]>
Signed-off-by: Joe Elliott <[email protected]>
Copy link
Contributor

@knylander-grafana knylander-grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating the docs! I only had a minor suggestion.

Copy link
Contributor

@ie-pham ie-pham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! just very small comments. Send it

integration/e2e/api_test.go Outdated Show resolved Hide resolved
tempodb/encoding/vparquet3/block_autocomplete_test.go Outdated Show resolved Hide resolved
tempodb/encoding/vparquet4/block_autocomplete_test.go Outdated Show resolved Hide resolved
@ie-pham
Copy link
Contributor

ie-pham commented Jul 10, 2024

Remember to let the front end folks know about the new feature ;)

joe-elliott and others added 2 commits July 10, 2024 15:34
Signed-off-by: Joe Elliott <[email protected]>
@joe-elliott joe-elliott merged commit 89e6789 into grafana:main Jul 10, 2024
15 checks passed
@joe-elliott joe-elliott mentioned this pull request Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants